[fix][ci] configure aws creds manually to avoid node20 issues on inco… #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddvenk
force-pushed
the
native-jni-pytorch-s3
branch
from
e32be9f to
59414a0
Compare
sindhuvahinis
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mpatible os
Description
This absolutely fun workaround is needed because all actions (like aws-actions/configure-aws-credentials@v2) that rely on Node have been forced by Github to use Node 20, but the way Node is used by external actions is by dynamically linking against libc. On AL2, the glibc is not compatible with Node 20 so everything breaks!
The solution is to just authenticate ourselves, which is a bit of a process with oidc + aws