feat: Make smock work with the EDR-powered version of Hardhat #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
changed the title
0xOneTony
reviewed
Feb 29, 2024
|
Thanks a lot for reviewing this @0xOneTony! I think I applied all your suggestions, and I also added a note in the readme. Let me know if you'd rather have that in a different place or with a different phrasing. I also updated typescript because I was getting a weird compilation error, which I think was related to bumping the version of |
fvictorio
force-pushed
the
prepare-for-hh-edr
branch
from
cf83476
to
991c227
Compare
0xGorilla
approved these changes
Mar 4, 2024
0xGorilla
added a commit
that referenced
this pull request
Mar 5, 2024
feat: make smock work with the EDR-powered version of Hardhat (#195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to release a new version of Hardhat this week that significantly changes its internals. Since Smock relies on several internal APIs, it will stop working with it. This PR makes the necessary changes for it to work.
This version of Smock won't work with previous versions of Hardhat. We've updated the peer dependency accordingly. Adding this change in a way that supported both new and old versions of Hardhat was possible, but too complex for the time we had to work on this.
The main change here is that, instead of taking a rxjs stream of call results and modifying their values, this version uses a callback that is executed for each call response. The callback can return
undefinedto leave the answer as is, or return a modified version of it. The sandbox uses the information about the call (the recipient address and the calldata) to figure out which mocked function to "ask" for the mocked answer.