Morpho allocator #36
Morpho allocator #36
Conversation
| } | ||
| `; | ||
|
|
||
| export const getReallocatableLiquidity = async (marketId: string, network: NetworkNumber = NetworkNumber.Eth): Promise<string> => { |
There was a problem hiding this comment.
Može jedan jsdoc koji objašnjava šta fja vraća? Nije mi bilo jasno bez čitanja sledeće funkcije da li je ovo marketId u koji ili iz kog se realocira
| const vaultTotalAssets = marketData.publicAllocatorSharedLiquidity.reduce( | ||
| (acc: Record<string, string>, item: MorphoBluePublicAllocatorItem) => { | ||
| const vaultAddress = item.vault.address; | ||
| acc[vaultAddress] = new Dec(acc[vaultAddress] || '0').add(item.assets).toString(); |
There was a problem hiding this comment.
da li da pitam uopšte u kom slučaju bi se isti vault našao više puta u listi ovde
There was a problem hiding this comment.
Svaki vault radi supply u vise marketa. Inicijalno je allocator bio samo namenjen za vaultove, da moze da se pomera supplied debt asset, u markete sa najvecom utilizacijom
Tako da vise vaultova moze da radi supply u isti market
I svaki vault radi supply u vise marketa
Many to many
| const vaults = Object.keys(withdrawalsPerVault); | ||
| const withdrawals = vaults.map( | ||
| (vaultAddress) => withdrawalsPerVault[vaultAddress], | ||
| ); |
There was a problem hiding this comment.
Object.values?
Nisam siguran ni ovako van konteksta zašto bi želeo povratnu vrednost u ovom obliku. Čak možda i vratiti samo withdrawalsPerVault?
| const liquidityToAllocate = '2375842896566685798032'; | ||
| const selectedMarket = sdk.markets.MorphoBlueMarkets(network)[sdk.MorphoBlueVersions.MorphoBlueWstEthEth_945]; | ||
|
|
||
| await sdk.helpers.morphoBlueHelpers.getReallocation(selectedMarket.marketId, liquidityToAllocate, network); |
There was a problem hiding this comment.
Možda neka validacija responsea ovde ako već pišemo testove, npr da li su vaults i withdrawals iste dužine, da li je suma withdrawala jednaka inputu, tako to.
Možda takođe koristiti return od getReallocatableLiquidity kao param za getReallocation?
No description provided.