Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized imports + adapted to breaking changes in OpenAI API for OpenAI evals #44

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Optimized imports + adapted to breaking changes in OpenAI API for OpenAI evals #44

merged 7 commits into from
Nov 7, 2023

Conversation

rishsriv
Copy link
Member

@rishsriv rishsriv commented Nov 6, 2023

  • Fixed imports in main.py, so that we only import necessary classes instead of importing all (and slowing the process down)
  • Adapted to the breaking changes in the OpenAI API

wongjingping
wongjingping approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@wongjingping wongjingping left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these! I especially liked the thinking behind the shifting of imports

@rishsriv rishsriv merged commit fbab8ad into main Nov 7, 2023
2 checks passed
@rishsriv rishsriv deleted the rishabh/fix-openai branch November 7, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongjingping wongjingping wongjingping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishsriv @wongjingping