Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New native #31

Merged
merged 14 commits into from
Jan 18, 2024
Merged

New native #31

merged 14 commits into from
Jan 18, 2024

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Jan 17, 2024

This is the 3/3 PR for Firebase.

Pay attention, that API has been changed.

The other PRs here:

  1. Remove FIR cpp SDK extension-firebase#12
  2. Remove FIR cpp SDK extension-firebase-remoteconfig#11

@AGulev AGulev requested a review from britzl January 17, 2024 16:47
britzl
britzl approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes! Looks good.

@AGulev AGulev merged commit 675e79e into master Jan 18, 2024
13 of 15 checks passed
@AGulev AGulev deleted the new-native branch January 18, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AGulev @britzl @Sippul