Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

fix dns in docker mode #104

Merged
merged 6 commits into from
Jul 19, 2024
Merged

fix dns in docker mode #104

merged 6 commits into from
Jul 19, 2024

Conversation

davidsiaw
Copy link
Collaborator

fix dns for docker mode

@degikko
Copy link
Collaborator

degikko commented Jul 18, 2024

@harsh-dk can you help us review this PR, please?

harsh-gulhane
harsh-gulhane previously approved these changes Jul 19, 2024
Copy link

@harsh-gulhane harsh-gulhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally Working!!!!

@davidsiaw
Copy link
Collaborator Author

@harsh-g31 can you please look again i just did a linter fix

Copy link

@harsh-gulhane harsh-gulhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@davidsiaw davidsiaw merged commit 6c78017 into master Jul 19, 2024
4 checks passed
@davidsiaw davidsiaw deleted the fix-dns-in-docker branch July 19, 2024 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants