Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hosted Fields Support #17

Merged
merged 15 commits into from
Jul 9, 2024
Merged

Conversation

Dinwy
Copy link
Collaborator

@Dinwy Dinwy commented Jul 2, 2024

Description

This PR is support for Komoju Hosted Fields, enhancing the payment integration by enabling hosted fields for credit card, bank transfer, and konbini payment methods. Key changes include the addition of a configuration to retrieve the publishable key, implementation of hosted fields, and maintaining the existing functionality for other payment methods.

Changes:

Configuration Updates:

  • Added a method in Config.php to retrieve the publishable_key, and updated the system.xml and config.xml files to include this new configuration setting.

Hosted Fields Implementation:

  • Integrated hosted fields for credit card, bank transfer, and konbini payment methods, enhancing user experience. This includes updating the frontend logic in form.js and form.html to support the hosted fields.
  • Publishable Key property has been added to support hosted field
    image

Maintaining Existing Functionality:

  • Ensured that other payment methods continue to function as before, without any disruption to the existing payment flow.

Concerns

  • There are some console error messages, does not block users to pay, however, I was not able to find a suitable way to prevent this.

Testing Videos

Scenario1: Credit Card

komoju_magento_credit_card_test.mov
Screenshot 2024-07-03 at 17 39 45 Screenshot 2024-07-03 at 17 40 18

Scenario2: Paypay (Non-hosted field supported payment method)

komoju_magento_paypay_test.mov
Screenshot 2024-07-03 at 17 44 57 Screenshot 2024-07-03 at 17 45 04

Scenario3: Konbini

komoju_magento_konbini_test.mov
Screenshot 2024-07-03 at 17 47 11 Screenshot 2024-07-03 at 17 47 04

Scenario4: Bank Transfer

komoju_magento_bank_transfer_test.mov
Screenshot 2024-07-03 at 17 49 22 Screenshot 2024-07-03 at 17 49 28

@Dinwy Dinwy force-pushed the feature/hostedFields branch from 282b35f to 4868034 Compare July 5, 2024 01:36
@Dinwy Dinwy changed the title WIP: [Feature] Hosted Fields Support [Feature] Hosted Fields Support Jul 5, 2024
@Dinwy Dinwy merged commit 3550e1d into degica:master Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant