Fix E2E admin spec #104
Merged
Fix E2E admin spec #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://requestbin.labs.degica.com is currently down for the count
|
@Resonious can you help us review this PR, please? |
|
@Resonious 🏓 This should get #102 unblocked too |
|
Ah!! Very nice. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes failing E2E: https://github.com/degica/komoju-woocommerce/commit/ac3e69bf64089a07c1b3d92f2481e99e70184909/checks/21135979902/logs
https://requestbin.labs.degica.com is currently down for the count, and after some discussion it seems ok to stop using it. In the failing spec the page wasn't loading so cypress hinted the spec exceeding the default
pageLoadTimeout, so this PR uses a more reliable 🤔 page to attempt and fail a KOMOJU account connection. I think it's safe to send the connection request to example.com?