add horizon adapter #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xroll
reviewed
May 7, 2024
Comment on lines
+150
to
+151
| token_symbol: `${positionSnapshot.pool.token0.symbol}/${positionSnapshot.pool.token1.symbol} HZN NFT`, | ||
| token_balance: positionSnapshot.liquidity, |
There was a problem hiding this comment.
we are looking at the underlying token balance of the lp position
0xroll
reviewed
May 7, 2024
Comment on lines
+135
to
+137
| } : findClosestTokenSnapshot(tokenPricingSnapshots.get(positionSnapshot.pool.token1.id), positionSnapshot.timestamp) | ||
| const token0Amount = parseFloat(positionSnapshot.depositedToken0) - parseFloat(positionSnapshot.withdrawnToken0); | ||
| const token1Amount = parseFloat(positionSnapshot.depositedToken1) - parseFloat(positionSnapshot.withdrawnToken1); |
There was a problem hiding this comment.
this wont be accurate, token balances are affected by swaps as well.
i see that you guys are CLMM dex, can you refer to sushi's code as reference?
we only want to track active positions (position that are in range)
https://github.com/delta-hq/l2-lxp-liquidity-reward/pull/37/files
|
@HorizonDex hi thanks for the pr, please check the comments. also can you provide your github repo link too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.