Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Add @Evolving and @since tags to all the Kernel API interfaces #2041

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

vkorukanti
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Kernel APIs are in the development phase. Add tags to indicate the APIs are evolving to set the expectations for API users.

Also, add a @since tag to indicate which version the API interface/method was introduced in. This is not done for the Kernel APIs in this PR. In the future, Kernel API docs can adopt the same.

The Delta-Spark module does extra labeling of evolving APIs by modifying the generated API

  • example javadoc, scaladoc, code
  • Evolving API label in Scala and Java docs. This is done by patching the generated HTML docs (code here and here)

How was this patch tested?

NA

Copy link
Collaborator

@scottsand-db scottsand-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 question about @since

@@ -48,7 +49,10 @@

/**
* Represents a scan of a Delta table.
*
* @since 3.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this wasn't totally clear to me in your PR description.

Why is this a comment? * @since 3.0.0 instead of an annotation like @Evolving below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@since is a tag supported by javadoc and evolving is not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

… class/method docs, if no docs are present on the implementation.
@vkorukanti vkorukanti merged commit 70ad00f into master Sep 12, 2023
11 checks passed
@vkorukanti vkorukanti deleted the evolve branch October 2, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants