Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark] Define and use DeltaTableV2.toLogicalRelation #2042

Closed
wants to merge 1 commit into from
Closed

[Spark] Define and use DeltaTableV2.toLogicalRelation #2042

wants to merge 1 commit into from

Conversation

ryan-johnson-databricks
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Most call sites of DeltaTableV2.toBaseRelation immediately use the result to create a LogicalRelation, using other fields of DeltaTableV2 as additional input. The duplicated code is not always consistent, either. Create helper methods toLogicalRelation and toDf which encapsulate the common-case logic for these operations.

How was this patch tested?

Unit tests

Does this PR introduce any user-facing changes?

No

LukasRupprecht
LukasRupprecht approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@LukasRupprecht LukasRupprecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasRupprecht LukasRupprecht LukasRupprecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-johnson-databricks @LukasRupprecht