Add truncate history support for DROP FEATURE command #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaschat-db
changed the title
andreaschat-db
changed the title
andreaschat-db
changed the title
andreaschat-db
changed the title
vkorukanti
approved these changes
Sep 12, 2023
| @@ -2462,18 +2519,25 @@ trait DeltaProtocolVersionSuiteBase extends QueryTest | |||
| } | |||
|
|
|||
| // If the property is re-disabled we pick up the issue during the history check. | |||
| val errorClass = if (reDisable) { | |||
| "DELTA_FEATURE_DROP_HISTORICAL_VERSIONS_EXIST" | |||
| if (reDisable) { | |||
There was a problem hiding this comment.
nit: seems like duplicated code, Can we revert to the earlier method?
There was a problem hiding this comment.
I am planning to follow up with refactor PR of drop feature tests. It should cover this issue as well.
Sure!
Technically, you could use the scala API but I do not see documentation for other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
The
DROP FEATUREcommand allows to drop table features from Delta Tables. Dropping a reader+writer feature is performed in two steps:This PR adds the
TRUNCATE HISTORYoption inDROP FEATUREcommand. The new option is automatically sets the history retention period to minimum and cleans up metadata. This operation occurs at the second time the user invokes the operation.How was this patch tested?
Added tests in DeltaProtocolVersionSuite and DeltaErrorsSuite.
Does this PR introduce any user-facing changes?
Introduces the TRUNCATE HISTORY option in ALTER TABLE ... DROP FEATURE command. This can be used as follows:
ALTER TABLE table_name DROP FEATURE feature_name [TRUNCATE HISTORY]The new option allows to truncate history older than the minimum retention period when dropping a reader+writer feature.