Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Rename DeltaTableV2.snapshot as initialSnapshot #2063

Conversation

ryan-johnson-databricks
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

DeltaTableV2.snapshot can be stale, if the object was instantiated long before the command using it. This can happen, for example, with a DeltaTable (which binds an internal DeltaTableV2 when constructed and never refreshes it). This can be dangerous, so we rename the field and document the danger so it is less likely to cause bugs.

How was this patch tested?

Field rename - compilation suffices.

Does this PR introduce any user-facing changes?

No

Copy link
Contributor

@LukasRupprecht LukasRupprecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants