[Kernel] Resolve path given to Table.forPath using TableClient APIs
#2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
commented
Sep 15, 2023
kernel/kernel-defaults/src/test/scala/io/delta/kernel/defaults/utils/TestUtils.scala
Outdated
Show resolved
Hide resolved
vkorukanti
force-pushed
the
resolvePath2
branch
from
8fc0f47
to
4f73539
Compare
...l/kernel-defaults/src/main/java/io/delta/kernel/defaults/client/DefaultFileSystemClient.java
Show resolved
Hide resolved
scottsand-db
approved these changes
Sep 15, 2023
| @@ -68,6 +68,11 @@ trait TestUtils extends Assertions { | |||
| } | |||
| } | |||
|
|
|||
| def latestSnapshot(path: String): Snapshot = { | |||
There was a problem hiding this comment.
@scottsand-db didn't we discuss explicitly not using this as a test API?
There was a problem hiding this comment.
i revert my opinion; im fine with this; thanks!
|
Standalone test is here https://github.com/delta-io/delta/blob/master/connectors/standalone/src/test/scala/io/delta/standalone/internal/DeltaLogSuite.scala#L159 if that helps |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Currently, we expect the path given to
Table.forPath()to be fully qualified. This enforces an unnecessary burden on the connector to add the necessary schema or authority etc. Instead, add aFileSystemClient.resolvePathAPI and use it to resolve the path to a fully qualified path fromTable.forPath().How was this patch tested?
Existing tests (deleted the
file:prefix added to tests tables in the path) and a couple of new tests around missing table paths.