[Kernel] Add support for nested column reference expression #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
approved these changes
Sep 19, 2023
kernel/kernel-api/src/main/java/io/delta/kernel/expressions/Column.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
vkorukanti
force-pushed
the
columnPathExpr
branch
from
3956a0c
to
6f88544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Part of #2071 (Partition Pruning in Kernel). We need a way to reference the
partitionValuesnested column in scan fileColumnarBatch.Currently, the
Columnexpression can only be used to refer to a top-level column. There is no way to refer to a nested column. This PR updates theColumnexpression to be a multi-part identifier. This is similar to the Spark'sNamedReferenceDSv2 expression.Fixes #2040 (also contains different approaches to refer to a nested column).
How was this patch tested?
Added a UT