[Spark] Rename DeltaSource.isStartingVersion to DeltaSource.isInitialSnapshot #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackierwzhang
approved these changes
Oct 5, 2023
xupefei
pushed a commit
to xupefei/delta
that referenced
this pull request
Oct 31, 2023
…Snapshot `DeltaSourceOffset.isStartingVersion` means "is this offset part of an initial snapshot", which is the exact opposite of `"startingVersion"` which is the user specified option that means "no initial snapshot, just changes starting at this version". This PR renames `isStartingVersion` to `isInitialSnapshot`, keeping the serialized name as "isStartingVersion". Closes delta-io#2139 GitOrigin-RevId: edcb79d942c597d5b4fd61820624951a717891a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
DeltaSourceOffset.isStartingVersionmeans "is this offset part of an initial snapshot", which is the exact opposite of"startingVersion"which is the user specified option that means "no initial snapshot, just changes starting at this version". This PR renamesisStartingVersiontoisInitialSnapshot, keeping the serialized name as "isStartingVersion".How was this patch tested?
Unit tests
Does this PR introduce any user-facing changes?
No