[Kernel] Move precondition checks from DefaultKernelUtils to Preconditions class

[rpinzon]

Which Delta project/connector is this regarding?

• Spark
• Standalone
• Flink
• Kernel
• Other (fill in here)

Description

Moves checkArgument methods from DefautKernelUtils to Preconditions class to clean up the code.

Resolves #2148

How was this patch tested?

Existing tests suffice.

Does this PR introduce any user-facing changes?

No

[vkorukanti]

lgtm, just one minor comment. Thank you for your contribution.

[rpinzon]

@vkorukanti since I synced the upstream changes today I can't build the project or import it into the IDE anymore. However, when I push to my branch the pipeline runs fine.

I double checked the building instructions but it doesn't appear to have changed.

Looking at the build log, I can see that all errors are related to missing classes/objects in iceberg. (see the log)

I tried to clone and build (build/sbt compile) the upstream (master) but I faced the same error.

Am I missing something?

[vkorukanti]

@vkorukanti since I synced the upstream changes today I can't build the project or import it into the IDE anymore. However, when I push to my branch the pipeline runs fine.

I double checked the building instructions but it doesn't appear to have changed.

Looking at the build log, I can see that all errors are related to missing classes/objects in iceberg. (see the log)

I tried to clone and build (build/sbt compile) the upstream (master) but I faced the same error.

Am I missing something?

I just noticed the master build is broken. Made a PR. Hopefully that should fix it, let me know if not.

[rpinzon]

@vkorukanti since I synced the upstream changes today I can't build the project or import it into the IDE anymore. However, when I push to my branch the pipeline runs fine.
I double checked the building instructions but it doesn't appear to have changed.
Looking at the build log, I can see that all errors are related to missing classes/objects in iceberg. (see the log)
I tried to clone and build (build/sbt compile) the upstream (master) but I faced the same error.
Am I missing something?

I just noticed the master build is broken. Made a PR. Hopefully that should fix it, let me know if not.

hey @vkorukanti, I'm not sure if your PR has already been merged into the master but I just tried to build the project and the error still occurs

[vkorukanti]

hey @vkorukanti, I'm not sure if your PR has already been merged into the master but I just tried to build the project and the error still occurs

The fix I mentioned is already landed on master. Can you try following steps to understand why the icebergShaded` classes are not found.

cd <delta - repo - directory>
rm -rf icebergShaded/lib/iceberg-*
python3 ./icebergShaded/generate_iceberg_jars.py

[rpinzon]

hey @vkorukanti, I'm not sure if your PR has already been merged into the master but I just tried to build the project and the error still occurs

The fix I mentioned is already landed on master. Can you try following steps to understand why the icebergShaded` classes are not found.

cd <delta - repo - directory>
rm -rf icebergShaded/lib/iceberg-*
python3 ./icebergShaded/generate_iceberg_jars.py

Following these steps I was able to find out that the JARs were not being generated in the icebergShaded/lib directory due to a configuration in my Gradle setup. For some reason the error is printed but the build does not fail.

Thank you very much for your help @vkorukanti.

[vkorukanti]

lgtm