[PROTOCOL] Fix inline DV example in PROTOCOL.md #3063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was generated when the encoding was incorrect in the code as well
vkorukanti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
The previous example was incorrect. It had the magic encoded in big-endian, but it should be little-endian. This fixes it.
To see that the previous one was incorrect, you can go to https://www.dcode.fr/ascii-85-encoding, and decode
wi5b=000010000siXQKl0rr91000f55c8Xg0@@D72lkbi5=-{L(be sure to select the zeromq encoding). The first 4 bytes of this decode to0x64, 0x39, 0xD3, 0xD0. This is1681511376(the correct magic), but only if you decode as Big endian.The new value decodes to
0xD1 0xD3 0x39 0x64, which is 1681511377 in little Endian.How was this patch tested?
Tested in this pr in the rust kernel
Does this PR introduce any user-facing changes?