Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mark reactions as IMAP-seen in marknoticed_chat() (#6210) #6213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Mark reactions as IMAP-seen in marknoticed_chat() (#6210) #6213

wants to merge 3 commits into from

Commits on Nov 26, 2024

  1. feat: Mark reactions as IMAP-seen in marknoticed_chat() (#6210) 

    When a reaction notification is shown in the UIs, there's an option "Mark Read", but the UIs are
unaware of reactions message ids, moreover there are no `msgs` rows for incoming reactions in the
core, so the UIs just call `marknoticed_chat()` in this case. We don't want to introduce reactions
message ids to the UIs (at least currently), but let's make received reactions usual messages, just
hidden and `InFresh`, so that the existing `\Seen` flag synchronisation mechanism works for them,
and mark all incoming hidden messages in the chat as seen in `marknoticed_chat()`.

It's interesting that sent out reactions are already hidden messages, so this change mostly just
unifies things.
    @iequidoo
    iequidoo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    fb1fbe4 View commit details
    Browse the repository at this point in the history

  2. 2squash: make reactions tests pass

    @iequidoo
    iequidoo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    40f11d3 View commit details
    Browse the repository at this point in the history

  3. 2squash: Optimize SQL statement and add db migration for hidden InFre… 

    …sh messages
    @iequidoo
    iequidoo committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3e8b050 View commit details
    Browse the repository at this point in the history