Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gke-cluster): update gke-cluster config #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

verbotenj
Copy link
Collaborator

@verbotenj verbotenj commented Nov 22, 2024

Closes #154

@verbotenj verbotenj force-pushed the gcp-dmtr-config branch 3 times, most recently from dc738e0 to 0d3f8ea Compare November 22, 2024 20:33
@verbotenj verbotenj force-pushed the gcp-dmtr-config branch 9 times, most recently from 52dafd8 to 29c5f66 Compare December 5, 2024 02:24
@verbotenj verbotenj force-pushed the gcp-dmtr-config branch 5 times, most recently from 380966d to c2d6e80 Compare December 18, 2024 19:15
@wolf31o2 wolf31o2 force-pushed the gcp-dmtr-config branch 3 times, most recently from 4948c1e to 8d048bc Compare December 19, 2024 18:50
@verbotenj verbotenj force-pushed the gcp-dmtr-config branch 2 times, most recently from 9af42a1 to d763cf7 Compare December 19, 2024 21:49
@verbotenj verbotenj marked this pull request as ready for review December 19, 2024 23:52
Signed-off-by: Ales Verbic <[email protected]>
Signed-off-by: Chris Gianelloni <[email protected]>
effect: NO_SCHEDULE
- key: demeter.run/compute-arch
value: "x86"
effect: NO_SCHEDULE
availability_zones: us-central1-a

- name: be-gp-arm64-az1
- name: be-di-arm64-az1
labels:
demeter.run/availability-sla: best-effort
demeter.run/compute-profile: general-purpose
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sla/profile here doesn't match the taints below.

availability_zones: us-central1-b

# Disk Intensive
- name: be-di-x86-az1
labels:
demeter.run/availability-sla: best-effort
demeter.run/compute-profile: general-purpose
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best-effort and general-purpose here, but consistent and disk-intensive below.

@@ -63,7 +63,7 @@ resource "helm_release" "cert-manager" {

set {
name = "tolerations[2].value"
value = "admin"
value = "consistent"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing these?

namespace = var.dmtr_namespace
source = "../modules/common/o11y/stage2"
namespace = var.dmtr_namespace
storage_class = "hyperdisk-balanced"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be gp on AWS and k3d.

storage_size = "10Gi"
storage_class_name = "gp-immediate"
storage_size = "50Gi"
storage_class_name = "hyperdisk-balanced-immediate"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be configurable.

stage3/nodes.tf Show resolved Hide resolved
@@ -57,29 +55,70 @@ module "ext_cardano_node" {
# topology_zone = "us-central1-a"
# node_resources = {
# limits = {
# "memory" = "16Gi"
# "cpu" = "8"
# "memory" = "4Gi"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24Gi is what I use with our helm chart.

# storage_size = "200Gi"
# storage_class_name = "gp"
# storage_size = "500Gi"
# storage_class_name = "pd-ssd"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be configurable when we uncomment.

}
}
storage_size = "50Gi"
storage_class_name = "hyperdisk-balanced"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants