-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gke-cluster): update gke-cluster config #164
base: main
Are you sure you want to change the base?
Conversation
dc738e0
to
0d3f8ea
Compare
52dafd8
to
29c5f66
Compare
380966d
to
c2d6e80
Compare
4948c1e
to
8d048bc
Compare
9af42a1
to
d763cf7
Compare
Signed-off-by: Ales Verbic <[email protected]> Signed-off-by: Chris Gianelloni <[email protected]>
d763cf7
to
db4b021
Compare
effect: NO_SCHEDULE | ||
- key: demeter.run/compute-arch | ||
value: "x86" | ||
effect: NO_SCHEDULE | ||
availability_zones: us-central1-a | ||
|
||
- name: be-gp-arm64-az1 | ||
- name: be-di-arm64-az1 | ||
labels: | ||
demeter.run/availability-sla: best-effort | ||
demeter.run/compute-profile: general-purpose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sla/profile here doesn't match the taints below.
availability_zones: us-central1-b | ||
|
||
# Disk Intensive | ||
- name: be-di-x86-az1 | ||
labels: | ||
demeter.run/availability-sla: best-effort | ||
demeter.run/compute-profile: general-purpose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's best-effort and general-purpose here, but consistent and disk-intensive below.
@@ -63,7 +63,7 @@ resource "helm_release" "cert-manager" { | |||
|
|||
set { | |||
name = "tolerations[2].value" | |||
value = "admin" | |||
value = "consistent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing these?
namespace = var.dmtr_namespace | ||
source = "../modules/common/o11y/stage2" | ||
namespace = var.dmtr_namespace | ||
storage_class = "hyperdisk-balanced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be gp
on AWS and k3d.
storage_size = "10Gi" | ||
storage_class_name = "gp-immediate" | ||
storage_size = "50Gi" | ||
storage_class_name = "hyperdisk-balanced-immediate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be configurable.
@@ -57,29 +55,70 @@ module "ext_cardano_node" { | |||
# topology_zone = "us-central1-a" | |||
# node_resources = { | |||
# limits = { | |||
# "memory" = "16Gi" | |||
# "cpu" = "8" | |||
# "memory" = "4Gi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24Gi is what I use with our helm chart.
# storage_size = "200Gi" | ||
# storage_class_name = "gp" | ||
# storage_size = "500Gi" | ||
# storage_class_name = "pd-ssd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be configurable when we uncomment.
} | ||
} | ||
storage_size = "50Gi" | ||
storage_class_name = "hyperdisk-balanced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this configurable
Closes #154