I/O and other small fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y pickle `Status` The second of these applies nicely if you want to pickle multiple `Status` objects into the same file with other data, for example, a list of binned fit results. It essentially allows pickle's load(s) and dump(s) methods to work directly on `Status` and any structures which contain `Status` (like a dict or list).
This allows "sum" to work.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 14 14
Lines 3932 3932
Branches 3932 3932
=======================================
Hits 3091 3091
Misses 813 813
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
CodSpeed Performance ReportMerging #18 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly adds methods that make it easy to pickle a
Status. It also adds some type hints that should allow the "sum" method in Python to actually work. The real trick for making "sum" work is allowing a no-op addition with 0, since that's what the sum method assumes as the starting value in the summation. There are now__radd__and__rmul__for every__add__and__mul__.