Skip to content

Commit

Permalink
Remove max validation for namepsace.workflowExecutionRetentionDays pr…
Browse files Browse the repository at this point in the history
…operty
  • Loading branch information
denniskniep committed Jan 9, 2024
1 parent 2c40a06 commit 95a3063
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 15 deletions.
12 changes: 2 additions & 10 deletions OWNERS.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
# OWNERS

This page lists all maintainers for **this** repository. Each repository in the [Crossplane
organization](https://github.com/crossplane/) will list their repository maintainers in their own
`OWNERS.md` file.

Please see the Crossplane
[GOVERNANCE.md](https://github.com/crossplane/crossplane/blob/master/GOVERNANCE.md) for governance
guidelines and responsibilities for the steering committee and maintainers.
This page lists all maintainers for **this** repository.

## Maintainers

* Nic Cope <[email protected]> ([negz](https://github.com/negz))
* Daniel Mangum <[email protected]> ([hasheddan](https://github.com/hasheddan))
* Muvaffak Onuş <[email protected]> ([muvaf](https://github.com/muvaf))
* Dennis Kniep <[email protected]> ([denniskniep](https://github.com/denniskniep))
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Temporal Provider

Provider Temporal is a [Crossplane](https://www.crossplane.io/) provider. It was build based on the [Crossplane Template](https://github.com/crossplane/provider-template). It is used to manage and configure [Temporal](https://temporal.io/). It uses the [Temporal Go SDK](https://github.com/temporalio/sdk-go)
Temporal Provider is a [Crossplane](https://www.crossplane.io/) provider. It was build based on the [Crossplane Template](https://github.com/crossplane/provider-template). It is used to manage and configure [Temporal](https://temporal.io/). It uses the [Temporal Go SDK](https://github.com/temporalio/sdk-go)

# How to use
Repository and package:
Expand Down Expand Up @@ -169,8 +169,7 @@ spec:
```
2. Replace the *core* group with your new group in apis/{provider}.go
3. Replace the *MyType* type with your new type in internal/controller/{provider}.go

4. Run `make reviewable` to run code generation, linters, and tests.
4. Run `make reviewable` to run code generation, linters, and tests. (`make generate` to only run code generation)
5. Run `make build` to build the provider.

Refer to Crossplane's [CONTRIBUTING.md] file for more information on how the
Expand Down
1 change: 0 additions & 1 deletion apis/core/v1alpha1/temporalnamespace_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ type TemporalNamespaceParameters struct {
// Workflow Execution retention.
// +kubebuilder:default=30
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:Maximum=30
WorkflowExecutionRetentionDays int `json:"workflowExecutionRetentionDays,omitempty"`

// +optional
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ spec:
workflowExecutionRetentionDays:
default: 30
description: Workflow Execution retention.
maximum: 30
minimum: 1
type: integer
required:
Expand Down

0 comments on commit 95a3063

Please sign in to comment.