feat(vendor): support using an existing import map #14836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
approved these changes
Jun 10, 2022
cli/tools/vendor/mod.rs
Outdated
Comment on lines
55
to
59
| "\nTo use vendored modules, specify the `--import-map {}` flag when ", | ||
| r#"invoking deno subcommands or add an `"importMap": "<path_to_vendored_import_map>"` "#, | ||
| "entry to your deno.json file.", | ||
| ), | ||
| raw_output_dir.join("import_map.json").display(), |
There was a problem hiding this comment.
Why is there an actual specifier for --import-map, but not for <path_to_vendored_import_map>?
There was a problem hiding this comment.
It's more complicated and I didn't think it was worth it. It would require checking where the config is and then doing different logic for whether the config existed or didn't exist. Plus, now it auto updates the config file if it exists.
|
@dsherret any chance we can land that for v1.23? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 (initial attempt was #14824).
./vendorfolder.Closes #13697