-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wget
fallback support for minimal OS's
#262
base: master
Are you sure you want to change the base?
Conversation
At the top of the installer script, it says "Keep this script simple". I'm not sure this change is simple since it's complicating the one-liners for most users. If you don't have curl installed in your minimal system, then you probably also know how to make the necessary adjustments. So I'd prefer not to add this change. |
In terms of script modification, do you know of a more simple way of addressing #256? my understanding was that the simplicity was so that other people could pretty easily verify the code wasn't malicious or vulnerable, which is definitely something I'm onboard with. I didn't think the complexity of the one liner fell into that, so I optimized it for minimal characters. would this be considered more simple?
I'm working with undergrad students who install the base version of Ubuntu which doesn't have curl, so they're not exactly skilled users. |
I think #256 is not really a deno_install issue, but rather a Ubuntu specific issue with some curl installations. Then again, I'm not a maintainer, just a contributor, so it's not my call. |
I think that we can add Here's what I suggest we do:
|
This should also fix #256. This PR has minimal edits to use wget as a fallback of curl, which is useful for Docker instances and other minimal OS's