Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report broken links #1116

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Report broken links #1116

merged 5 commits into from
Nov 18, 2024

Conversation

oscarotero
Copy link
Contributor

@oscarotero oscarotero commented Nov 7, 2024

I've upgraded the Lume version to 2.4.1 and added the check_urls plugin to detect broken links.
The list of broken links is exported to _broken_links.json (which is ignored by git).
This is a copy of the report in my computer (keys are the broken links, and the values the pages where they have been found):

{
  "http://localhost:8000": [
    "/deploy/manual/"
  ],
  "http://example.com": [
    "/deploy/manual/middleware/",
    "/runtime/tutorials/fetch_data/"
  ],
  "https://example.com": [
    "/deploy/manual/middleware/"
  ],
  "http://localhost:8000/": [
    "/deploy/tutorials/tutorial-wordpress-frontend/",
    "/runtime/fundamentals/http_server/"
  ],
  "http://localhost/wp-admin": [
    "/deploy/tutorials/tutorial-wordpress-frontend/"
  ],
  "https://some.url/a.ts": [
    "/runtime/fundamentals/modules/"
  ],
  "https://docs.deno.com/api/deno/~/Deno.File": [
    "/deploy/api/runtime-fs/"
  ],
  "https://my-personal-blog-kcbxc4xwe4mc.deno.dev": [
    "/deploy/manual/deployctl/"
  ],
  "http://localhost:8080/": [
    "/runtime/tutorials/chat_app/",
    "/runtime/tutorials/word_finder/"
  ],
  "http://0.0.0.0:8000/": [
    "/runtime/tutorials/file_server/"
  ],
  "/api/deno/Deno.open": [
    "/runtime/tutorials/fetch_data/"
  ],
  "/ry": [
    "/runtime/tutorials/how_to_with_npm/redis/"
  ],
  "http://jsr.io:443": [
    "/runtime/reference/cli/check/",
    "/runtime/reference/cli/documentation_generator/",
    "/runtime/reference/cli/dependency_inspector/"
  ],
  "http://raw.githubusercontent.com:443": [
    "/runtime/reference/cli/check/",
    "/runtime/reference/cli/documentation_generator/",
    "/runtime/reference/cli/dependency_inspector/"
  ],
  "http://user.githubusercontent.com:443": [
    "/runtime/reference/cli/check/",
    "/runtime/reference/cli/documentation_generator/",
    "/runtime/reference/cli/dependency_inspector/"
  ],
  "/api/deno/sub-process": [
    "/runtime/reference/deno_namespace_apis/"
  ],
  "/api/deno/~/Deno.serveHttp": [
    "/runtime/reference/deno_namespace_apis/"
  ],
  "/api/node/fs--promises": [
    "/runtime/reference/node_apis/"
  ],
  "/api/node/readilne": [
    "/runtime/reference/node_apis/"
  ],
  "https://github.com/denoland/deno/blob/2.0.5/cli/tsc/dts/lib.deno.window.d.ts": [
    "/runtime/reference/web_platform_apis/"
  ],
  "https://github.com/denoland/deno/blob/2.0.5/cli/tsc/dts/lib.deno.worker.d.ts": [
    "/runtime/reference/web_platform_apis/"
  ],
  "https://github.com/denoland/deno/blob/2.0.5/cli/tsc/dts/lib.deno.shared_globals.d.ts": [
    "/runtime/reference/web_platform_apis/"
  ],
  "/examples/dependency-management": [
    "/examples/import-export/"
  ],
  "https://github.com/denoland/deno-docs/blob/main/examples/importing-json.ts/main": [
    "/examples/importing-json/"
  ],
  "https://github.com/denoland/deno-docs/blob/main/examples/import-export.ts/main": [
    "/examples/import-export/"
  ],
  "https://github.com/denoland/deno-docs/blob/main/examples/web-workers.ts/main": [
    "/examples/web-workers/"
  ],
  "https://hub.docker.com/repositories": [
    "/runtime/tutorials/aws_lightsail/"
  ]
}

Some broken links are examples of urls (example.com or localhost:8000, etc). But I don't think they should be real links in the HTML.

@thisisjofrank
Copy link
Collaborator

oh interesting, this is picking up stuff that our link checker isn't. I'll take a look thank you!

@thisisjofrank thisisjofrank self-requested a review November 7, 2024 18:30
@thisisjofrank thisisjofrank merged commit 2504d2b into denoland:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants