refactor(path): always name the parameters (add param definition check in doc linter) #6158
+53
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6158 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 536 536
Lines 40765 40769 +4
Branches 6118 6118
=======================================
+ Hits 39347 39351 +4
Misses 1374 1374
Partials 44 44 ☔ View full report in Codecov by Sentry. |
efekrskl
changed the title
kt3k
changed the title
kt3k
reviewed
Oct 30, 2024
| @@ -26,8 +26,9 @@ export type { GlobOptions }; | |||
| */ | |||
| export function joinGlobs( | |||
| globs: string[], | |||
| { extended = true, globstar = false }: GlobOptions = {}, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5439
This implementation doesn't go well with unnamed parameters (see the other changes in
path/*). IMO, this is ok. As named parameters and Jsdoc param names go hand in hand, especially considering these are public APIs. Also, immediately on implementation, this helped me uncover some unused fields in the same functions. I'm curious on your opinions on this.