-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expect): support expect.addSnapshotSerializer
#6173
Merged
kt3k
merged 8 commits into
denoland:main
from
eryue0220:fix/expect-add-snapshot-serialize
Nov 6, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c7514de
fix: add expect.addSnapshotSerializer api
eryue0220 ed2e6dc
fix: ci
eryue0220 d353420
fix: ci
eryue0220 d945ffb
fix: ci
eryue0220 b6742d9
feat: add test code
eryue0220 69c67ae
Merge branch 'main' into fix/expect-add-snapshot-serialize
eryue0220 c0a1d27
docs: modify function description
kt3k b2112a7
Merge branch 'main' into fix/expect-add-snapshot-serialize
eryue0220 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. | ||
|
||
import type { SnapshotPlugin } from "./_types.ts"; | ||
|
||
const INTERNAL_PLUGINS: SnapshotPlugin[] = [ | ||
// TODO(eryue0220): support internal snapshot serializer plugins | ||
]; | ||
|
||
export function addSerializer(plugin: SnapshotPlugin) { | ||
INTERNAL_PLUGINS.unshift(plugin); | ||
} | ||
|
||
export function getSerializer() { | ||
return INTERNAL_PLUGINS; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. | ||
|
||
import { expect } from "./expect.ts"; | ||
import { addSerializer, getSerializer } from "./_serializer.ts"; | ||
import type { SnapshotPlugin } from "./_types.ts"; | ||
|
||
const foo: SnapshotPlugin = { | ||
serialize() { | ||
return "foot"; | ||
}, | ||
test() { | ||
return false; | ||
}, | ||
}; | ||
|
||
Deno.test("initial serializer", () => { | ||
expect(getSerializer()).toHaveLength(0); | ||
}); | ||
|
||
Deno.test("add serializer", () => { | ||
addSerializer(foo); | ||
expect(getSerializer()).toHaveLength(1); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
OldSnapshotPlugin
still common? How about only supportingNewSnapshotPlugin
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I checked some serialize plugins, they still use
OldSnapshottPlugin
type definition, like:jest-serializer-vue
jest-serializer-html
jest-serializer-react-helmet
jest-snapshot-serializer-ansi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough