docs(log): improve logger.ts docs #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6176 +/- ##
==========================================
- Coverage 96.49% 96.49% -0.01%
==========================================
Files 535 535
Lines 41275 41281 +6
Branches 6163 6163
==========================================
+ Hits 39829 39833 +4
- Misses 1402 1404 +2
Partials 44 44 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
Nov 7, 2024
| * | ||
| * const handler = new ConsoleHandler("INFO"); | ||
| * const logConfig: LogConfig = { | ||
| * handlers: { |
There was a problem hiding this comment.
We generally prefer 2-space indent here, but not a big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets us closer to #3764
The file was already very well documented, it was just missing a few things