Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bytes): fix typo in test description #6179

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

BinskLee
Copy link
Contributor

@BinskLee BinskLee commented Nov 9, 2024

Fix typo in test description.

@BinskLee BinskLee requested a review from kt3k as a code owner November 9, 2024 07:41
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bytes label Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (bf0ad52) to head (3456776).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6179   +/-   ##
=======================================
  Coverage   96.48%   96.49%           
=======================================
  Files         535      535           
  Lines       41281    41281           
  Branches     6163     6163           
=======================================
+ Hits        39832    39833    +1     
+ Misses       1405     1404    -1     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BinskLee BinskLee changed the title fix(test): typo in test description. fix: typo in test description. Nov 9, 2024
@kt3k kt3k changed the title fix: typo in test description. test(bytes): fix typo in test description Nov 9, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 69858cf into denoland:main Nov 9, 2024
20 of 21 checks passed
@kt3k
Copy link
Member

kt3k commented Nov 9, 2024

a bit curious why this wasn't caught by our typo checker in CI

@BinskLee BinskLee deleted the fix-typo branch November 9, 2024 13:49
@BinskLee
Copy link
Contributor Author

@kt3k I think it's because of the following line, clearing that setting caught the wrong typo.

"*_test.ts",

@kt3k
Copy link
Member

kt3k commented Nov 12, 2024

Ah, thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants