Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toml): parsing positive time zone offset #6188

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

IgorM867
Copy link
Contributor

Currently, this code throws an error:

toml.parse("time = 1979-05-27T00:32:00+07:00")

According to the TOML specification, this should parse successfully.

Fixes #6187

@IgorM867 IgorM867 requested a review from kt3k as a code owner November 14, 2024 09:22
@github-actions github-actions bot added the toml label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (7490085) to head (f767e9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6188      +/-   ##
==========================================
- Coverage   96.48%   95.87%   -0.61%     
==========================================
  Files         536      517      -19     
  Lines       41314    41156     -158     
  Branches     6169     6078      -91     
==========================================
- Hits        39860    39460     -400     
- Misses       1409     1651     +242     
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@kt3k kt3k merged commit 90e4aef into denoland:main Nov 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Parsing Positive Time Zone Offset (+07:00) in @std/toml
2 participants