Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): use locale-independent letter case methods (#6016) #6204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lionel-rowe
Copy link
Contributor

Closes #6016

@lionel-rowe lionel-rowe force-pushed the text-locale-independent-letter-case branch from 33c4a3b to aaf3999 Compare November 22, 2024 07:25
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (a73ff94) to head (b328479).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6204      +/-   ##
==========================================
+ Coverage   96.52%   96.54%   +0.01%     
==========================================
  Files         533      533              
  Lines       40870    40868       -2     
  Branches     6120     6120              
==========================================
+ Hits        39451    39454       +3     
+ Misses       1377     1372       -5     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member

kt3k commented Nov 23, 2024

Could this change/fix any output with Turkish locale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of locale-sensitive methods with undefined locale may cause environment-sensitive bugs
2 participants