Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regexp): escape leading digit #6208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 23, 2024

This PR updates escape of @std/regexp. Now escape escapes the leading digit as recommended in #3656. This behavior is aligned with regexp-escape proposal ( https://github.com/tc39/proposal-regex-escaping, polyfill: https://npm.im/regexp.escape )

closes #3656

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (4989ba7) to head (7a8b7c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6208   +/-   ##
=======================================
  Coverage   96.52%   96.53%           
=======================================
  Files         533      533           
  Lines       40871    40872    +1     
  Branches     6120     6120           
=======================================
+ Hits        39451    39456    +5     
+ Misses       1378     1374    -4     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regexp.escape needs to escape leading digits
1 participant