Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate strict annotations, changes from bake #358

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

Harfusha
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.14286% with 24 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (ceee64c) to head (74653ea).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/View/Helper/DocBlockHelper.php 0.00% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
- Coverage     83.50%   83.41%   -0.10%     
- Complexity     1799     1807       +8     
============================================
  Files           114      114              
  Lines          4923     4949      +26     
============================================
+ Hits           4111     4128      +17     
- Misses          812      821       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereuromark
Copy link
Owner

dereuromark commented Oct 15, 2024

cakephp/bake#1002 (comment)

I wonder if also those new generics here in the param arguments should be a feature flag to opt-in.

@Harfusha
Copy link
Contributor Author

I will resolve this issue in cakephp/bake and then here

@Harfusha
Copy link
Contributor Author

Will name the flag genericsInInputs, do you have any better name for it? :D

config/app.example.php Outdated Show resolved Hide resolved
@dereuromark dereuromark merged commit 2f25a6a into dereuromark:master Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants