Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate strict annotations followup #359

Merged

Conversation

Harfusha
Copy link
Contributor

Adam Halfar added 2 commits October 17, 2024 08:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.40%. Comparing base (49ccd37) to head (e8a811e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Annotator/ControllerAnnotator.php 75.00% 1 Missing ⚠️
src/View/Helper/DocBlockHelper.php 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #359      +/-   ##
============================================
- Coverage     83.41%   83.40%   -0.02%     
- Complexity     1807     1808       +1     
============================================
  Files           114      114              
  Lines          4949     4952       +3     
============================================
+ Hits           4128     4130       +2     
- Misses          821      822       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereuromark dereuromark merged commit dee3e6b into dereuromark:master Oct 17, 2024
8 checks passed
@dereuromark
Copy link
Owner

Most of this can probably be ported back to bake I guess.

@Harfusha
Copy link
Contributor Author

I will port it tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants