include cmake rules for third party libraries only if it needed #66
Conversation
| @@ -117,6 +117,9 @@ function(link_libabsl target_name) | |||
| endif() | |||
| endif() | |||
| if (NOT absl_FOUND) | |||
| if (NOT TARGET libabsl) | |||
There was a problem hiding this comment.
Why other cases don't do this check?
There was a problem hiding this comment.
Only link_libabsl called twice. Will I add this check to other cases?
There was a problem hiding this comment.
In theory any of them could be called any amount of times
|
Hey, I finally tested your PR on CI. Unfortunately, it still makes snap fail, just like your previous PRs. You should find another way to do that. https://github.com/ilya-fedin/tdesktop/runs/3626654353?check_suite_focus=true |
|
Windows CI failed as well MacOS CI is broken at the moment, but I guess it would fail as well |
|
@vitlav will there be any further work or the PR can be closed? |
I still can't open the CI logs :( |
Why can't you open them? |
|
Maybe you have JS disabled or some extensions like uMatrix? It uses AJAX to fetch the logs. You can click on the gear and download log archive. |
|
@vitlav are you still busy? looks like you got some merge conflicts |
Perhaps #85 is "another way"? |
|
@vitlav there were no work for more than half of a year (github says 7 months), maybe close the PR and re-open when you would have time to work on this? |
|
#85 has the same problems as your PR |
|
There are conflicts now |
I think this PR can be closed as stale and duplicate of #85. |
|
I was unable to pursue preston to close it :( |
Ever when TG_OWT_PACKAGED_BUILD is used, the cmake rules for embedded (third party) sources are still included and they access the third party sources.
This patch fixed that incorrect behaviour and allows build with system libraries without third party sources using.