Build on OpenBSD #79

klemensn · 2021-12-14T23:48:55Z

These are required to build on OpenBSD/amd64 7.0 -CURRENT.

Both net/tg_owt and net/tdesktop have been ported to OpenBSD and widely tested already.
tg_owt is built as shared library and I'd like to avoid carrying local patches as best as possible.

src/rtc_base/platform_thread_types.cc

src/rtc_base/platform_thread_types.h

klemensn · 2021-12-15T22:38:35Z

All comments are addressed, this builds on OpenBSD, does not effect other non-POSIX platforms and should still build fine on POSIX platforms.

Thanks for the feedback.

cmake/libusrsctp.cmake

ilya-fedin · 2021-12-15T22:53:44Z

Looks like I found where pid_t comes from: https://man7.org/linux/man-pages/man2/gettid.2.html
Apparently, it should be

#elif defined(WEBRTC_POSIX)
#if defined(WEBRTC_MAC) || defined(WEBRTC_IOS)
typedef mach_port_t PlatformThreadId;
#elif defined(WEBRTC_LINUX)
typedef pid_t PlatformThreadId;
#else
typedef intptr_t PlatformThreadId;
#endif
typedef pthread_t PlatformThreadRef;

klemensn · 2021-12-15T23:03:19Z

I have amended it once more, but you might as well commit this on your own in an OpenBSD unrelated commit, imho.

klemensn · 2021-12-22T11:55:24Z

Brief reminder. Anything else that comes to mind or is this good enough to go in?

ilya-fedin · 2021-12-22T12:05:15Z

I have no more suggestions, so we have to wait until @john-preston will have time to look on that

klemensn · 2021-12-22T12:14:46Z

Thanks, good to know.

ilya-fedin · 2021-12-22T13:26:40Z

Please, no unneeded changes (such as adding extra logging)

src/modules/audio_device/audio_device_impl.cc

klemensn · 2022-01-23T20:58:50Z

@john-preston any feedback on this?

I just rebased it onto master after your libvpx changes and everything builds fine on OpenBSD.
It would be great to get these merged eventually so we can stop carrying local patches.

Otherwise building as Linux results in compile errors like symbol redifinition; the code is already OpenBSD aware.

Same as the others.

@ilya-fedin

pthread_self(3) returns a phtread_t (aka. pthread *) value. With @ilya-fedin: Redefine thread IDs as `intptr_t` on POSIX platforms unless platform specific functions/types exist so as to avoid the following warning on OpenBSD/amd64 7.0 using clang 11.1.0: ``` platform_thread_types.cc:57:10: error: cast from pointer to smaller type 'rtc::PlatformThreadId' (aka 'int') loses information return reinterpret_cast<PlatformThreadId>(pthread_self()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ``` At least Solaris defines `pid_t` as `long`, i.e. that warning would not occur. OpenBSD defines `pid_t` as `int`. Linux uses its non-portable gettid(3) returing a `pid_t` value, so stick with that.

klemensn · 2022-02-09T09:23:50Z

Rebased once more after conflicts in cmake/libusrtsctp.cmake.

ilya-fedin · 2022-02-16T04:11:22Z

@klemensn what's your native language?

src/rtc_base/platform_thread_types.cc

@ilya-fedin

Suggested by @ilya-fedin, thanks! Co-authored-by: ilya-fedin <[email protected]>

klemensn changed the title ~~openbsd~~ Build on OpenBSD Dec 14, 2021