-
Notifications
You must be signed in to change notification settings - Fork 359
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: remove e2e_slurm_misconfigured series tests (#10023)
The only test in this series was an e2e test that the log shipper ships a certain log in a certain situation. We have unit tests for that, so delete the e2e test. Now, I actually failed this e2e test when I first landed the log shipper, so it wasn't totally good-for-nothing. But effectively, all it was testing these days was that we did in fact use the new log shipper in slurm workloads. Now that the EE code is merged into the OSS code, and we can just use the same LogShipperWrappedEntrypoint() function in all three classes of resource manager, I don't see any real justification for this test. This is part of a larger effort to get rid of our znode tests, which are notoriously unreliable.
- Loading branch information
1 parent
b243c26
commit 2356f91
Showing
6 changed files
with
2 additions
and
128 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters