Skip to content

Commit

Permalink
build: INFENG-938: Tweak version string format (#10139)
Browse files Browse the repository at this point in the history
Restore previous version tag format, which places a hyphen '-' between
the patch revision part and the remainder of the version string. So, for
example, instead of a string like v0.38.0rc3, we will look for
v0.38.0-rc3. The former is not SemVer-compliant, whereas the latteris.

This fixes an issue where Helm breaks when using release candidate
versions, because it expects the string to be
SemVer-compliant. Setuptools, by contrast, can munge the hyphenated
version into a more canonical PEP 440-compliant format, so we prefer the
new SemVer-compliant format instead.
  • Loading branch information
davidfluck-hpe authored Oct 26, 2024
1 parent 30ad3c0 commit 27bebdd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .circleci/real_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ release-and-rc-filters: &release-and-rc-filters
- /.*/
tags:
only:
# Tags like: v2.5.0, v3.0.1+rc2
- /v\d+\.\d+\.\d+(rc\d+)?/
# Tags like: v2.5.0, v3.0.1-rc2
- /v\d+\.\d+\.\d+(-rc\d+)?/

rc-filters: &rc-filters
branches:
ignore:
- /.*/
tags:
only:
# Tags like: v2.5.0rc3
- /v\d+\.\d+\.\d+rc\d+/
# Tags like: v2.5.0-rc3
- /v\d+\.\d+\.\d+-rc\d+/

release-filters: &release-filters
branches:
Expand Down

0 comments on commit 27bebdd

Please sign in to comment.