Fix flat run action button

determined-ai · Oct 21, 2024 · 74db3c5 · 74db3c5
1 parent 389a5c7
commit 74db3c5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/webui/react/src/pages/FlatRuns/FlatRunActionButton.test.tsx b/webui/react/src/pages/FlatRuns/FlatRunActionButton.test.tsx
@@ -29,6 +29,7 @@ const setup = (selectedFlatRuns: ReadonlyArray<Readonly<FlatRun>>) => {
         projectId={1}
         selectedRuns={selectedFlatRuns}
         selection={{ selections: selectedFlatRuns.map((run) => run.id), type: 'ONLY_IN' }}
+        selectionSize={selectedFlatRuns.length}
         tableFilterString=""
         workspaceId={1}
         onActionComplete={onActionComplete}

diff --git a/webui/react/src/pages/FlatRuns/FlatRunActionButton.tsx b/webui/react/src/pages/FlatRuns/FlatRunActionButton.tsx
@@ -61,6 +61,7 @@ interface Props {
   onActionSuccess?: (action: BatchAction, successfulIds: number[]) => void;
   onActionComplete?: () => void | Promise<void>;
   selection: SelectionType;
+  selectionSize: number;
 }
 
 const FlatRunActionButton = ({
@@ -69,6 +70,7 @@ const FlatRunActionButton = ({
   selectedRuns,
   projectId,
   selection,
+  selectionSize,
   workspaceId,
   onActionSuccess,
   onActionComplete,
@@ -254,7 +256,7 @@ const FlatRunActionButton = ({
 
   return (
     <>
-      {selectedRuns.length > 0 && (
+      {selectionSize > 0 && (
         <Dropdown menu={editMenuItems} onClick={handleBatchAction}>
           <Button hideChildren={isMobile} icon={<Icon decorative name="pencil" />}>
             Actions

diff --git a/webui/react/src/pages/FlatRuns/FlatRuns.tsx b/webui/react/src/pages/FlatRuns/FlatRuns.tsx
@@ -1037,6 +1037,7 @@ const FlatRuns: React.FC<Props> = ({ projectId, workspaceId, searchId }) => {
               projectId={projectId}
               selectedRuns={loadedSelectedRuns}
               selection={settings.selection}
+              selectionSize={selectionSize}
               tableFilterString={filtersString}
               workspaceId={workspaceId}
               onActionComplete={onActionComplete}