fix: use columnDefKey as default parameter

determined-ai · Oct 23, 2024 · 78dda83 · 78dda83
1 parent 2626927
commit 78dda83
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/webui/react/src/pages/FlatRuns/FlatRuns.tsx b/webui/react/src/pages/FlatRuns/FlatRuns.tsx
@@ -400,10 +400,10 @@ const FlatRuns: React.FC<Props> = ({ projectId, workspaceId, searchId }) => {
               !settings.heatmapSkipped.includes(currentColumn.column)
             ) {
               columnDefs[columnDefKey] = defaultNumberColumn(
-                currentColumn.column,
+                columnDefKey,
                 currentColumn.displayName || currentColumn.column,
-                settings.columnWidths[currentColumn.column] ??
-                  defaultColumnWidths[currentColumn.column as RunColumn] ??
+                settings.columnWidths[columnDefKey] ??
+                  defaultColumnWidths[columnDefKey as RunColumn] ??
                   MIN_COLUMN_WIDTH,
                 dataPath,
                 {
@@ -413,10 +413,10 @@ const FlatRuns: React.FC<Props> = ({ projectId, workspaceId, searchId }) => {
               );
             } else {
               columnDefs[columnDefKey] = defaultNumberColumn(
-                currentColumn.column,
+                columnDefKey,
                 currentColumn.displayName || currentColumn.column,
-                settings.columnWidths[currentColumn.column] ??
-                  defaultColumnWidths[currentColumn.column as RunColumn] ??
+                settings.columnWidths[columnDefKey] ??
+                  defaultColumnWidths[columnDefKey as RunColumn] ??
                   MIN_COLUMN_WIDTH,
                 dataPath,
                 undefined,
@@ -426,20 +426,20 @@ const FlatRuns: React.FC<Props> = ({ projectId, workspaceId, searchId }) => {
           }
           case V1ColumnType.DATE:
             columnDefs[columnDefKey] = defaultDateColumn(
-              currentColumn.column,
+              columnDefKey,
               currentColumn.displayName || currentColumn.column,
-              settings.columnWidths[currentColumn.column] ??
-                defaultColumnWidths[currentColumn.column as RunColumn] ??
+              settings.columnWidths[columnDefKey] ??
+                defaultColumnWidths[columnDefKey as RunColumn] ??
                 MIN_COLUMN_WIDTH,
               dataPath,
             );
             break;
           case V1ColumnType.ARRAY:
             columnDefs[columnDefKey] = defaultArrayColumn(
-              currentColumn.column,
+              columnDefKey,
               currentColumn.displayName || currentColumn.column,
-              settings.columnWidths[currentColumn.column] ??
-                defaultColumnWidths[currentColumn.column as RunColumn] ??
+              settings.columnWidths[columnDefKey] ??
+                defaultColumnWidths[columnDefKey as RunColumn] ??
                 MIN_COLUMN_WIDTH,
               dataPath,
             );
@@ -448,10 +448,10 @@ const FlatRuns: React.FC<Props> = ({ projectId, workspaceId, searchId }) => {
           case V1ColumnType.UNSPECIFIED:
           default:
             columnDefs[columnDefKey] = defaultTextColumn(
-              currentColumn.column,
+              columnDefKey,
               currentColumn.displayName || currentColumn.column,
-              settings.columnWidths[currentColumn.column] ??
-                defaultColumnWidths[currentColumn.column as RunColumn] ??
+              settings.columnWidths[columnDefKey] ??
+                defaultColumnWidths[columnDefKey as RunColumn] ??
                 MIN_COLUMN_WIDTH,
               dataPath,
             );