Skip to content

Commit

Permalink
fix: ban archive columns in filter for experiment/search search (#10172)
Browse files Browse the repository at this point in the history
  • Loading branch information
ashtonG authored Oct 31, 2024
1 parent 85a5d22 commit b4e7fa9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion webui/react/src/components/Searches/Searches.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ interface Props {
project: Project;
}

const BANNED_FILTER_COLUMNS = new Set(['searcherMetricsVal']);
const BANNED_FILTER_COLUMNS = new Set(['searcherMetricsVal', 'archived']);
const BANNED_SORT_COLUMNS = new Set(['tags', 'searcherMetricsVal']);

const makeSortString = (sorts: ValidSort[]): string =>
Expand Down
2 changes: 1 addition & 1 deletion webui/react/src/pages/F_ExpList/F_ExperimentList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ interface Props {

const NO_PINS_WIDTH = 200;

export const BANNED_FILTER_COLUMNS = new Set(['searcherMetricsVal']);
export const BANNED_FILTER_COLUMNS = new Set(['searcherMetricsVal', 'archived']);
const BANNED_SORT_COLUMNS = new Set(['tags', 'searcherMetricsVal']);

const makeSortString = (sorts: ValidSort[]): string =>
Expand Down

0 comments on commit b4e7fa9

Please sign in to comment.