chore: attend to PR comments

determined-ai · Oct 31, 2024 · b7187bc · b7187bc
1 parent 79c4bd0
commit b7187bc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/webui/react/src/components/FilterForm/components/FilterFormStore.ts b/webui/react/src/components/FilterForm/components/FilterFormStore.ts
@@ -242,8 +242,9 @@ export class FilterFormStore {
     col: Pick<V1ProjectColumn, 'location' | 'type' | 'column'>,
   ): void {
     return this.#updateField(id, (form) => {
-      if (form.columnName === col.column) {
-        if (form.type === col.type && form.location === col.location) return form;
+      const isSameColumn = form.columnName === col.column && form.type === col.type;
+      if (isSameColumn && form.location === col.location) {
+        return form;
       }
       return {
         ...form,