Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct expToWebhookConfig cache locking #10014

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: correct expToWebhookConfig cache locking #10014

merged 1 commit into from
Oct 3, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 3, 2024

Ticket

CM-527

Description

There is a write under a read lock, causing the master to crash in integration tests with fatal error: concurrent map writes.

Test Plan

Change is a test fix.

@stoksc stoksc requested a review from a team as a code owner October 3, 2024 13:24
@stoksc stoksc requested a review from amandavialva01 October 3, 2024 13:24
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@stoksc stoksc requested a review from gt2345 October 3, 2024 13:25
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.58%. Comparing base (25ca6d0) to head (f5a7e38).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10014      +/-   ##
==========================================
- Coverage   54.59%   54.58%   -0.02%     
==========================================
  Files        1258     1258              
  Lines      157136   157136              
  Branches     3617     3616       -1     
==========================================
- Hits        85795    85771      -24     
- Misses      71208    71232      +24     
  Partials      133      133              
Flag Coverage Δ
backend 45.33% <100.00%> (-0.05%) ⬇️
harness 72.74% <ø> (ø)
web 54.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/webhooks/postgres_webhook.go 45.83% <100.00%> (-0.18%) ⬇️

... and 6 files with indirect coverage changes

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit f5a7e38
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66fe9b2da7c9730008b716a3
😎 Deploy Preview https://deploy-preview-10014--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@stoksc stoksc enabled auto-merge (squash) October 3, 2024 18:49
@stoksc stoksc merged commit ddca766 into main Oct 3, 2024
90 of 102 checks passed
@stoksc stoksc deleted the cm527 branch October 3, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants