chore: check task config policies against slots and max_slots #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10015 +/- ##
==========================================
- Coverage 54.58% 54.57% -0.02%
==========================================
Files 1259 1259
Lines 157233 157236 +3
Branches 3619 3619
==========================================
- Hits 85831 85816 -15
- Misses 71269 71287 +18
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kkunapuli
commented
Oct 3, 2024
| @@ -153,7 +153,7 @@ func (a *apiServer) getCommandLaunchParams(ctx context.Context, req *protoComman | |||
| // Check submitted config against task config policies. | |||
| valid, err := configpolicy.CheckNTSCConstraints(ctx, int(cmdSpec.Metadata.WorkspaceID), config, a.m.rm) | |||
| if !valid { | |||
| return nil, nil, err | |||
| return nil, nil, status.Errorf(codes.InvalidArgument, "failed constraint check: %v", err) | |||
There was a problem hiding this comment.
@amandavialva01 I had %w here at first, but the formatting was super weird. I was reminded of the conversation we had about %v vs. %w in fmt.Errorf. Eventually I'll (hopefully) keep it straight! 😆
There was a problem hiding this comment.
Loll same! 😄 It's definitely a matter of trial and error 😆
kkunapuli
requested review from
maxrussell and
amandavialva01
and removed request for
maxrussell
Comment on lines
+125
to
+126
| config.Resources.Slots = *config.Resources.MaxSlots | ||
| config.Resources.MaxSlots = nil // ensure only slots is set |
There was a problem hiding this comment.
I like this setup! Makes the test function explicit
amandavialva01
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-551
Description
Need to check both
resources.max_slotsandresources.slotswhen checking if a NTSC workload requests is within constraints.Test Plan
Covered by automated tests.
Checklist
docs/release-notes/See Release Note for details.