Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run checkpoint GC more aggressively to ensure tensorboards are GC'd #10017

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 3, 2024

Ticket

CM-540

Description

Unfortunately we can't be clever about skipping checkpoint GC since there still may be tensorboard files.

Test Plan

Tested manually and left a comment so this change isn't undone.

@stoksc stoksc requested a review from a team as a code owner October 3, 2024 18:48
@stoksc stoksc requested a review from jesse-amano-hpe October 3, 2024 18:48
@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0088cfd
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66fee6f0cee7220008a26528
😎 Deploy Preview https://deploy-preview-10017--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.59%. Comparing base (a0cc818) to head (0088cfd).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/api_experiment.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10017   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files        1259     1259           
  Lines      157245   157244    -1     
  Branches     3620     3618    -2     
=======================================
+ Hits        85843    85846    +3     
+ Misses      71269    71265    -4     
  Partials      133      133           
Flag Coverage Δ
backend 45.35% <71.42%> (+<0.01%) ⬆️
harness 72.74% <ø> (ø)
web 54.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/experiment.go 30.12% <ø> (ø)
master/internal/api_experiment.go 57.06% <71.42%> (+0.23%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, sorry I didn't notice this PR in my inbox. Looks great -- I should've approved two weeks ago.

@stoksc stoksc merged commit e796b92 into main Oct 16, 2024
85 of 98 checks passed
@stoksc stoksc deleted the cm540 branch October 16, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants