Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check experiment constraints #10018

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Oct 3, 2024

Ticket

CM-491

Description

Check if experiment config passes any constraints defined in task config policies.

Test Plan

Covered by unit tests.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a2e8c89
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6700045f6f73b000088dfcdc

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (80b29fa) to head (a2e8c89).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10018      +/-   ##
==========================================
+ Coverage   54.60%   59.19%   +4.59%     
==========================================
  Files        1259      755     -504     
  Lines      157329   104947   -52382     
  Branches     3621     3620       -1     
==========================================
- Hits        85902    62122   -23780     
+ Misses      71294    42692   -28602     
  Partials      133      133              
Flag Coverage Δ
backend 43.80% <ø> (-1.54%) ⬇️
harness 72.74% <ø> (ø)
web 54.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 504 files with indirect coverage changes

@kkunapuli kkunapuli marked this pull request as ready for review October 4, 2024 15:22
@kkunapuli kkunapuli requested a review from a team as a code owner October 4, 2024 15:22
@kkunapuli kkunapuli requested review from hamidzr, carolinaecalderon and amandavialva01 and removed request for hamidzr October 4, 2024 15:22
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkunapuli kkunapuli merged commit 5b1380c into main Oct 7, 2024
84 of 96 checks passed
@kkunapuli kkunapuli deleted the kunapuli/experiment-constraints branch October 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants