Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Global Config Policies UI [CM-522] #10022

Merged
merged 4 commits into from
Oct 10, 2024
Merged

feat: Global Config Policies UI [CM-522] #10022

merged 4 commits into from
Oct 10, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Oct 4, 2024

Ticket

CM-522, CM-521

Description

Adds page for Global Config Policies UI

Test Plan

Only in EE:
Should display "Config Policies" as option in Navigation Sidebar.
"Config Policies" Page should display secondary tabs for "Experiments" and "Tasks"
Non-admin should not see Apply button, and should see CodeEditor in read-only mode.
Admin should be able to Apply (with valid YAML syntax that modifies what's fetched).
Should be able to remove all YAML and Apply without error.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner October 4, 2024 19:19
@johnkim-det johnkim-det requested a review from hkang1 October 4, 2024 19:19
@cla-bot cla-bot bot added the cla-signed label Oct 4, 2024
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 9d2e3b5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6706b0baeaddee00083bf5d7
😎 Deploy Preview https://deploy-preview-10022--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 63.40206% with 71 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (80b29fa) to head (9d2e3b5).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/pages/ConfigPoliciesPage.tsx 0.00% 25 Missing and 1 partial ⚠️
webui/react/src/components/ConfigPolicies.tsx 64.06% 23 Missing ⚠️
webui/react/src/components/NavigationSideBar.tsx 0.00% 9 Missing ⚠️
webui/react/src/services/apiConfig.ts 77.50% 9 Missing ⚠️
webui/react/src/routes/index.tsx 0.00% 2 Missing ⚠️
webui/react/src/routes/utils.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10022      +/-   ##
==========================================
- Coverage   54.60%   50.58%   -4.02%     
==========================================
  Files        1259      950     -309     
  Lines      157329   128826   -28503     
  Branches     3621     3636      +15     
==========================================
- Hits        85902    65169   -20733     
+ Misses      71294    63523    -7771     
- Partials      133      134       +1     
Flag Coverage Δ
harness ?
web 54.40% <63.40%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/hooks/usePermissions.ts 75.14% <100.00%> (+0.73%) ⬆️
webui/react/src/routes/routes.ts 100.00% <100.00%> (ø)
webui/react/src/services/api.ts 97.86% <100.00%> (+0.03%) ⬆️
webui/react/src/routes/index.tsx 0.00% <0.00%> (ø)
webui/react/src/routes/utils.ts 68.72% <33.33%> (-0.42%) ⬇️
webui/react/src/components/NavigationSideBar.tsx 0.00% <0.00%> (ø)
webui/react/src/services/apiConfig.ts 74.24% <77.50%> (+0.05%) ⬆️
webui/react/src/components/ConfigPolicies.tsx 73.87% <64.06%> (+5.77%) ⬆️
webui/react/src/pages/ConfigPoliciesPage.tsx 0.00% <0.00%> (ø)

... and 310 files with indirect coverage changes

@johnkim-det johnkim-det requested review from gt2345 and removed request for hkang1 October 4, 2024 19:22
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments added

Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messages LGTM

Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, had a few nits

webui/react/src/components/ConfigPolicies.tsx Outdated Show resolved Hide resolved
webui/react/src/components/ConfigPolicies.tsx Outdated Show resolved Hide resolved
@johnkim-det johnkim-det requested a review from ashtonG October 9, 2024 16:35
@johnkim-det johnkim-det merged commit 30b197d into main Oct 10, 2024
82 of 94 checks passed
@johnkim-det johnkim-det deleted the CM-522 branch October 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants