Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: INFENG-885: add lock-api-state.sh pre-commit check #10030

Closed
wants to merge 55 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
92a6fad
* Add pre-commit step to replace lock-api-state.sh, which ensures that
davidfluck-hpe Oct 8, 2024
6162a90
* Add files key for lock-api-state pre-commit entry.
davidfluck-hpe Oct 8, 2024
4a0066b
* Tweak files key for lock-api-state pre-commit hook.
davidfluck-hpe Oct 8, 2024
a50e7e9
* Set pass_filenames: false on lock-api-state pre-commit hook, because
davidfluck-hpe Oct 8, 2024
1fbfbc4
* Add commit stage specifier to lock-api-state pre-commit hook.
davidfluck-hpe Oct 8, 2024
ffa433c
Test change
davidfluck-hpe Oct 8, 2024
fba7db9
Remove commit stage from lock-api-state hook.
davidfluck-hpe Oct 8, 2024
45592da
Test
davidfluck-hpe Oct 8, 2024
1e72803
Update pre-commit/lock-api-state.sh to install protobuf deps.
davidfluck-hpe Oct 8, 2024
63569ca
Add verbose: true to debug lock-api-state hook.
davidfluck-hpe Oct 8, 2024
a157f95
* Add actions/setup-go@v5 to the pre-commit GitHub Action. This is
davidfluck-hpe Oct 8, 2024
d22a667
lock-api-state precommit hook, verbose: false
davidfluck-hpe Oct 8, 2024
9be6717
Put protobuf back.
davidfluck-hpe Oct 8, 2024
ed7aa78
Tweak lock-api-state hook description.
davidfluck-hpe Oct 8, 2024
26901b8
Debug lock-api-state.sh
davidfluck-hpe Oct 8, 2024
e0c0b0c
Debug
davidfluck-hpe Oct 9, 2024
9ae8f2f
Remove debug statements, remove pass_filenames.
davidfluck-hpe Oct 9, 2024
5f7a473
Set extra_args to "" for the pre-commit hook, otherwise it runs on all
davidfluck-hpe Oct 9, 2024
3ce6bea
Test proto/ change.
davidfluck-hpe Oct 9, 2024
2fb5c9d
Output arguments
davidfluck-hpe Oct 9, 2024
91253f8
shfmt
davidfluck-hpe Oct 9, 2024
622b124
Test
davidfluck-hpe Oct 9, 2024
c18ede8
verbose: true
davidfluck-hpe Oct 9, 2024
88658da
Tweak regex
davidfluck-hpe Oct 9, 2024
cc0ed5b
Test
davidfluck-hpe Oct 9, 2024
092e55e
Tweak regex
davidfluck-hpe Oct 9, 2024
305d378
Test
davidfluck-hpe Oct 9, 2024
8f45751
Tweak regex. Again.
davidfluck-hpe Oct 9, 2024
322a440
Test
davidfluck-hpe Oct 9, 2024
e3892bf
Degenerate regex.
davidfluck-hpe Oct 9, 2024
0308f9c
Test
davidfluck-hpe Oct 9, 2024
d40f99f
OG regex and remove extra_args.
davidfluck-hpe Oct 9, 2024
8fba3ee
Fix regex.
davidfluck-hpe Oct 9, 2024
b6f0d5a
Fix key and terrible quoting typo.
davidfluck-hpe Oct 9, 2024
b821b0f
Remove debug statement.
davidfluck-hpe Oct 9, 2024
5112d1b
Remove test lines.
davidfluck-hpe Oct 9, 2024
464de79
Add regenerated buf.image.bin.
davidfluck-hpe Oct 9, 2024
e52f7cf
Move protobuf dependency installation to GitHub Action.
davidfluck-hpe Oct 9, 2024
154aca5
Add lock-published-urls pre-commit step, along with the requisite
davidfluck-hpe Oct 9, 2024
be87464
Test something
davidfluck-hpe Oct 10, 2024
d020ad3
Test
davidfluck-hpe Oct 10, 2024
e4d3c49
Test.
davidfluck-hpe Oct 10, 2024
68fd4ba
verbose: true
davidfluck-hpe Oct 10, 2024
94260b2
verbose: true
davidfluck-hpe Oct 10, 2024
c64d6e6
Restore proto deps installation.
davidfluck-hpe Oct 11, 2024
fffdae5
Test
davidfluck-hpe Oct 11, 2024
61ae691
Test
davidfluck-hpe Oct 11, 2024
928c977
Test
davidfluck-hpe Oct 11, 2024
5f3cfb4
Test
davidfluck-hpe Oct 11, 2024
b99f167
Remove verbose.
davidfluck-hpe Oct 11, 2024
4c2add1
Fix pre-commit.yml spacing to clean up diff.
davidfluck-hpe Oct 14, 2024
3bd33b0
Delete lock-api-state.sh and lock-published-urls.sh from
davidfluck-hpe Oct 14, 2024
ef8f679
Add lock-published-urls make target for docs. This cleans up the
davidfluck-hpe Oct 14, 2024
be4ad8f
Remove lock-api-state.sh section from tools/scripts/README.md.
davidfluck-hpe Oct 14, 2024
a033120
Remove unhelpful comment.
davidfluck-hpe Oct 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test
  • Loading branch information
davidfluck-hpe committed Oct 14, 2024
commit d020ad3ee426c1a81e975583b877feffcb5fb9d6
1 change: 1 addition & 0 deletions proto/src/determined/api/v1/api.proto
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Test
syntax = "proto3";

package determined.api.v1;