test: rbac config [TESTENG-108] #10032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JComins000
force-pushed
the
jcom/TESTENG-108/rbac-config
branch
from
2df5e3f to
bef7c3c
Compare
JComins000
commented
Oct 9, 2024
| security: | ||
| initial_user_password: $INITIAL_USER_PASSWORD | ||
| authz: | ||
| rbac_ui_enabled: true |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10032 +/- ##
==========================================
- Coverage 54.49% 54.47% -0.03%
==========================================
Files 1267 1267
Lines 159437 159437
Branches 3637 3637
==========================================
- Hits 86885 86849 -36
- Misses 72419 72455 +36
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
looks like there are quite a few tests that fail with |
JComins000
force-pushed
the
jcom/TESTENG-108/rbac-config
branch
from
b8bf99d to
aeec193
Compare
JComins000
force-pushed
the
jcom/TESTENG-108/rbac-config
branch
from
aeec193 to
fa6c2c1
Compare
amandavialva01
approved these changes
Oct 14, 2024
davidfluck-hpe
approved these changes
Oct 15, 2024
johnkim-det
force-pushed
the
jcom/TESTENG-108/rbac-config
branch
from
9419b27 to
8cbd13f
Compare
johnkim-det
force-pushed
the
jcom/TESTENG-108/rbac-config
branch
from
8cbd13f to
569997e
Compare
|
@JComins000 went ahead and added fixes for test failures. Hopefully we can move forward with the PR if that looks good. |
djanicekpach
approved these changes
Oct 28, 2024
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
Co-authored-by: John Kim <[email protected]>
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
Co-authored-by: John Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
TESTENG-108
Description
adds rbac devcluster config and uses it in e2e-react-ee
Test Plan
Checklist
docs/release-notes/See Release Note for details.