Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests to the "move project" functionality on the "List View" #10034

Closed
wants to merge 6 commits into from

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Oct 9, 2024

Ticket

ET-757

Description

Adds e2e tests for the "move project" functionality on the "List View" for the WorkspaceProjects.

Test Plan

  • run the e2e tests on the projects.spec file
    • all tests should pass

Screenshot 2024-10-09 at 17 59 57

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c18c78c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6707e98917dcf200083ec88c
😎 Deploy Preview https://deploy-preview-10034--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.62%. Comparing base (30b197d) to head (c18c78c).

Files with missing lines Patch % Lines
...t/src/pages/WorkspaceDetails/WorkspaceProjects.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10034      +/-   ##
==========================================
- Coverage   54.61%   50.62%   -4.00%     
==========================================
  Files        1260      950     -310     
  Lines      157507   128863   -28644     
  Branches     3631     3631              
==========================================
- Hits        86030    65235   -20795     
+ Misses      71343    63494    -7849     
  Partials      134      134              
Flag Coverage Δ
harness ?
web 54.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t/src/pages/WorkspaceDetails/WorkspaceProjects.tsx 0.00% <0.00%> (ø)

... and 318 files with indirect coverage changes

@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-757 branch October 10, 2024 14:58
@thiagodallacqua-hpe thiagodallacqua-hpe restored the thiago/ET-757 branch October 10, 2024 15:12
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/ET-757 branch October 11, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants